Skip to content

Update gemma3_causal_lm_preprocessor.py #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

Update gemma3_causal_lm_preprocessor.py #2217

merged 3 commits into from
Apr 17, 2025

Conversation

pctablet505
Copy link
Collaborator

@pctablet505 pctablet505 commented Apr 17, 2025 •
edited
Loading

Added checks for invalid inputs, raising error to prevent segmentation faults.

Resolves #2205

@pctablet505
Update gemma3_causal_lm_preprocessor.py
af584b4 
Added checks for invalid inputs
@pctablet505 pctablet505 requested a review from abheesht17 April 17, 2025 04:58
@github-actions github-actions bot added the Gemma Gemma model specific issues label Apr 17, 2025
abheesht17
abheesht17 approved these changes Apr 17, 2025
View reviewed changes
Copy link
Collaborator

@abheesht17 abheesht17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Rahul!

@abheesht17 abheesht17 added the kokoro:force-run Runs Tests on GPU label Apr 17, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Apr 17, 2025
abheesht17
abheesht17 reviewed Apr 17, 2025
View reviewed changes
Copy link
Collaborator

@abheesht17 abheesht17 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, let's do the same thing in generate_preprocess() before merging

@divyashreepathihalli divyashreepathihalli merged commit 0b63ce0 into keras-team:master Apr 17, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abheesht17 abheesht17 abheesht17 approved these changes

Assignees
No one assigned
Labels
Gemma Gemma model specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on Gemma3 token_embedding Layer During Training
4 participants
@pctablet505 @abheesht17 @kokoro-team @divyashreepathihalli