Skip to content

Fix up package build scripts again #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix up package build scripts again #2230

wants to merge 1 commit into from

Conversation

mattdangerw
Copy link
Member

  • Better error checking (check we got back the .whl files we expect).
  • Decompose functions a little further.
  • Fix licensing warning (there's new license names I guess).
  • Make version file path agree with core Keras.

@mattdangerw
Fix up package build scripts with better error checking
8d3c3b9 
- Better error checking (check we got back the `.whl` files we expect).
- Decompose functions a little further.
- Fix licensing warning (there's new license names I guess).
- Make version file path agree with core Keras.
@mattdangerw
Copy link
Member Author

Actually testing this end to end finally https://github.com/keras-team/keras-hub/actions/runs/14653739129

@mattdangerw mattdangerw requested a review from hertschuh April 25, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hertschuh hertschuh hertschuh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattdangerw @hertschuh