Skip to content

Conversation

@pctablet505
Copy link
Collaborator

This pull request updates the project to use Python 3.11 and Keras 3.13 as the new minimum requirements, and updates the CI workflows and package metadata accordingly. These changes ensure compatibility with the latest versions and streamline the development and deployment processes.

Dependency and compatibility updates:

  • Updated minimum required Python version to 3.11 in pyproject.toml, removed Python 3.9 and 3.10 from the supported classifiers, and set requires-python = ">=3.11".
  • Updated minimum required Keras version to 3.13 in pyproject.toml (keras>=3.13).

Continuous Integration workflow updates:

  • Updated all GitHub Actions workflows (actions.yml, nightly.yml, publish-to-pypi.yml) to use Python 3.11 instead of 3.10 [1] [2] [3] [4].
  • Updated the Keras version in the test matrix and pinning steps in actions.yml to use Keras 3.13 instead of 3.9 [1] [2].

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @pctablet505, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's core dependencies by upgrading the minimum required Python version to 3.11 and the Keras framework to 3.13. These updates are crucial for maintaining compatibility with the latest software versions, leveraging performance improvements, and ensuring the project's development and deployment processes remain streamlined and robust.

Highlights

  • Python Version Update: The minimum required Python version has been updated to 3.11, removing support for Python 3.9 and 3.10 from the project's metadata.
  • Keras Version Update: The minimum required Keras version has been updated to 3.13.
  • CI Workflow Alignment: Continuous Integration workflows have been updated to utilize Python 3.11 and Keras 3.13, ensuring compatibility with the new dependency requirements.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/actions.yml
    • .github/workflows/nightly.yml
    • .github/workflows/publish-to-pypi.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's dependencies, setting the minimum Python version to 3.11 and Keras to 3.13. The changes in pyproject.toml correctly reflect this by updating requires-python, removing obsolete Python version classifiers, and bumping the Keras version requirement. I have added one comment to improve the clarity of supported Python versions in the package metadata. Overall, the changes are beneficial for the project.

@pctablet505 pctablet505 added the kokoro:force-run Runs Tests on GPU label Dec 18, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Dec 18, 2025
@sachinprasadhs
Copy link
Collaborator

We need to Keep the Keras 3.9(3-4 versions before the current version) to ensure backward compatibility tests.
If any of your code is failing due to Keras version<3.13, you can add the condition something like.

 if packaging.version.parse(keras.__version__) < packaging.version.parse("3.13"):
            self.skipTest("Failing on keras lower version")

@pctablet505
Copy link
Collaborator Author

We need to Keep the Keras 3.9(3-4 versions before the current version) to ensure backward compatibility tests. If any of your code is failing due to Keras version<3.13, you can add the condition something like.

 if packaging.version.parse(keras.__version__) < packaging.version.parse("3.13"):
            self.skipTest("Failing on keras lower version")

Can we just upgrade python from 3.10 to 3.11 in that case, that will make it possible to install keras 3.13

@sachinprasadhs
Copy link
Collaborator

Yes, we can update python.

Downgrade JAX backend test to Keras 3.9 in CI workflow and update dependency to keras>=3.9 in pyproject.toml. Also, require Python >=3.11 and remove support for Python 3.9 and 3.10 in project metadata.
Changed the Python version from 3.11 to 3.10 in GitHub Actions workflows for nightly and PyPI publishing. Added Python 3.9 and 3.10 classifiers to pyproject.toml to reflect supported versions.
@pctablet505
Copy link
Collaborator Author

@sachinprasadhs
I've modified only to force python upgrade from 3.10 to 3.11 that automatically allows keras 3.13

@sachinprasadhs
Copy link
Collaborator

Can you rebase your code and fix the merge conflict, now the minimum version for Keras has been updated to 3.12.

@sachinprasadhs
Copy link
Collaborator

Python version update and other items are included in the PR here #2489, I think you can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants