-
Notifications
You must be signed in to change notification settings - Fork 312
Python update clean #2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Python update clean #2474
Conversation
Added checks for invalid inputs
Added tests to check invalid inputs
Fix for model not loading when using numpy behaviour with tensorflow
This reverts commit 3fdc7fd.
Summary of ChangesHello @pctablet505, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's core dependencies by upgrading the minimum required Python version to 3.11 and the Keras framework to 3.13. These updates are crucial for maintaining compatibility with the latest software versions, leveraging performance improvements, and ensuring the project's development and deployment processes remain streamlined and robust. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the project's dependencies, setting the minimum Python version to 3.11 and Keras to 3.13. The changes in pyproject.toml correctly reflect this by updating requires-python, removing obsolete Python version classifiers, and bumping the Keras version requirement. I have added one comment to improve the clarity of supported Python versions in the package metadata. Overall, the changes are beneficial for the project.
This reverts commit 49008bb.
|
We need to Keep the Keras 3.9(3-4 versions before the current version) to ensure backward compatibility tests. |
Can we just upgrade python from 3.10 to 3.11 in that case, that will make it possible to install keras 3.13 |
|
Yes, we can update python. |
Downgrade JAX backend test to Keras 3.9 in CI workflow and update dependency to keras>=3.9 in pyproject.toml. Also, require Python >=3.11 and remove support for Python 3.9 and 3.10 in project metadata.
Changed the Python version from 3.11 to 3.10 in GitHub Actions workflows for nightly and PyPI publishing. Added Python 3.9 and 3.10 classifiers to pyproject.toml to reflect supported versions.
|
@sachinprasadhs |
|
Can you rebase your code and fix the merge conflict, now the minimum version for Keras has been updated to 3.12. |
|
Python version update and other items are included in the PR here #2489, I think you can close this PR. |
This pull request updates the project to use Python 3.11 and Keras 3.13 as the new minimum requirements, and updates the CI workflows and package metadata accordingly. These changes ensure compatibility with the latest versions and streamline the development and deployment processes.
Dependency and compatibility updates:
pyproject.toml, removed Python 3.9 and 3.10 from the supported classifiers, and setrequires-python = ">=3.11".pyproject.toml(keras>=3.13).Continuous Integration workflow updates:
actions.yml,nightly.yml,publish-to-pypi.yml) to use Python 3.11 instead of 3.10 [1] [2] [3] [4].actions.ymlto use Keras 3.13 instead of 3.9 [1] [2].