Skip to content

Add Meta CLIP2 presets#2626

Open
sachinprasadhs wants to merge 2 commits intokeras-team:masterfrom
sachinprasadhs:register_metaclip2
Open

Add Meta CLIP2 presets#2626
sachinprasadhs wants to merge 2 commits intokeras-team:masterfrom
sachinprasadhs:register_metaclip2

Conversation

@sachinprasadhs
Copy link
Collaborator

Description of the change

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and works with all backends (TensorFlow, JAX, and PyTorch).
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have followed the Keras Hub Model contribution guidelines in making these changes.
  • I have followed the Keras Hub API design guidelines in making these changes.
  • I have signed the Contributor License Agreement.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new model configurations for MetaCLIP 2, making a range of pre-trained Vision Transformer models readily available for use. This expands the library's capabilities by providing access to different scales and resolutions of these powerful models, facilitating their integration and experimentation within the Keras ecosystem.

Highlights

  • New MetaCLIP 2 Presets: Added four new MetaCLIP 2 model presets: metaclip_2_vit_huge_patch14_224, metaclip_2_vit_huge_patch14_378, metaclip_2_vit_giant_patch14_224, and metaclip_2_vit_giant_patch14_378.
  • Detailed Model Metadata: Each new preset includes comprehensive metadata such as a detailed description of the model's architecture (e.g., layer counts, patch size, image resolution), total parameter count, and a Kaggle handle for easy access.
  • Expanded Model Configurations: The added presets define configurations for various MetaCLIP 2 Vision Transformer (ViT) models, offering different scales and resolutions to enhance flexibility for users.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • keras_hub/src/models/metaclip_2/metaclip_2_presets.py
    • Populated the backbone_presets dictionary with four new MetaCLIP 2 model configurations.
    • Included detailed metadata for each preset, such as model description, parameter count, and Kaggle URL.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds four new presets for the MetaCLIP 2 model. The structure of the presets file is correct and follows the repository's conventions. However, there are significant discrepancies between the parameter counts listed in the description strings and the params fields for all four presets. The params values, likely generated automatically, appear to be correct, while the descriptions are misleading. I've added specific comments to correct the parameter counts in the descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants