Fixes bert_vocab_uncased.txt dataset links#2047
Merged
hertschuh merged 1 commit intokeras-team:masterfrom Feb 26, 2025
Merged
Conversation
JyotinderSingh
requested review from
MarkDaoust,
fchollet and
pcoet
as code owners
divyashreepathihalli
approved these changes
Feb 12, 2025
Collaborator
divyashreepathihalli
left a comment
divyashreepathihalli
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
hertschuh
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently the links for the
bert_vocab_uncased.txtpoint to https://storage.googleapis.com/tensorflow/keras-hub/examples/bert/bert_vocab_uncased.txt which doesn't lead anywhere. This PR replaces the link with https://storage.googleapis.com/tensorflow/keras-nlp/examples/bert/bert_vocab_uncased.txtThis seems to have broken during a previous renaming exercise renaming
keras-nlp->keras-hub.