-
Notifications
You must be signed in to change notification settings - Fork 2.1k
A guide to using the Function Calling feature with Keras Hub models #2133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A guide to using the Function Calling feature with Keras Hub models #2133
Conversation
divyashreepathihalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nits
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new guide on using function calling with Keras Hub models, including examples for both Gemma and Mistral. The guide is provided as a Jupyter notebook, a Python script, and a Markdown file.
Overall, the guide is well-structured and provides a good walkthrough of the function calling feature. However, I've identified a few issues, including a critical bug in the agent loop logic that could cause a crash, some code quality concerns that could set a bad example for users, and some rendering issues in the Markdown version of the guide that make it difficult to follow.
Addressing these points will significantly improve the quality and reliability of this new guide.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new guide on using the function calling feature with KerasHub models, specifically Gemma and Mistral. The review focuses on improving the guide's correctness, security, and maintainability, and has identified a critical security issue, a high-severity bug, and several medium-severity issues related to code efficiency and formatting.
|
/gemini review |
|
Warning Gemini is unable to generate a review due to a potential policy violation. |
1 similar comment
|
Warning Gemini is unable to generate a review due to a potential policy violation. |
|
/gemini review |
|
Warning Gemini is unable to generate a review due to a potential policy violation. |
I’ve been working on a guide for function calling with KerasHub models. This final version uses the Gemma and Mistral models from KerasHub as demonstration examples.
In this guide, we’ll walk through a basic example of function calling with Gemma 3 and Mistral models on KerasHub. The steps include:
This approach showcases how to integrate external tools with KerasHub models for enhanced, interactive workflows
Refer working colab gist