-
Notifications
You must be signed in to change notification settings - Fork 2.1k
update .md and .ipynb #2139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update .md and .ipynb #2139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @divyashreepathihalli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements a focused bug fix to the Transformer model's loss calculation logic within the transformer_asr example. The change ensures that the model correctly references its own compute_loss method during training and evaluation steps, which is crucial for the model's proper functioning and accurate loss reporting. The correction is mirrored in both the executable notebook and its static markdown representation.
Highlights
- Code Correction: I've identified a critical correction in how the
compute_lossmethod is invoked within theTransformermodel. Previously, it was incorrectly callingmodel.compute_loss, implying an externalmodelobject, but it has been updated toself.compute_loss, ensuring the model correctly uses its own defined loss computation method. - Consistency Across Formats: The same
compute_lossmethod call correction has been applied consistently across both the Jupyter Notebook (.ipynb) and its corresponding Markdown (.md) version of thetransformer_asrexample, maintaining code integrity in both interactive and documentation formats.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a critical bug by correcting the call to compute_loss within the Transformer model's train_step and test_step methods. The original code incorrectly used model.compute_loss instead of self.compute_loss, which would have caused a NameError.
| " one_hot = tf.one_hot(dec_target, depth=self.num_classes)\n", | ||
| " mask = tf.math.logical_not(tf.math.equal(dec_target, 0))\n", | ||
| " loss = model.compute_loss(None, one_hot, preds, sample_weight=mask)\n", | ||
| " loss = self.compute_loss(None, one_hot, preds, sample_weight=mask)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| " one_hot = tf.one_hot(dec_target, depth=self.num_classes)\n", | ||
| " mask = tf.math.logical_not(tf.math.equal(dec_target, 0))\n", | ||
| " loss = model.compute_loss(None, one_hot, preds, sample_weight=mask)\n", | ||
| " loss = self.compute_loss(None, one_hot, preds, sample_weight=mask)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.