Skip to content

Conversation

@shashaka
Copy link
Contributor

I added the following functions to api_master.py:

keras.ops.kaiser
keras.ops.hanning
keras.ops.cbrt
keras.ops.deg2rad

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @shashaka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've introduced new Keras ops APIs to support Keras 3.11.0. This change primarily involves adding four new functions to the api_master.py script, which expands the set of available operations within the Keras framework. Additionally, I've updated the Keras version reference in autogen.py to align with the new Keras 3.11.0 compatibility.

Highlights

  • New Keras Ops API additions: I've added keras.ops.kaiser, keras.ops.hanning, keras.ops.cbrt, and keras.ops.deg2rad to api_master.py, expanding the available operations in Keras.
  • Keras Version Update: I've updated the Keras version reference in scripts/autogen.py from v3.10.0 to v3.11.0 to reflect the new Keras compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for new operations in Keras 3.11.0 by updating the API documentation configuration. Specifically, it adds keras.ops.kaiser, keras.ops.hanning, keras.ops.cbrt, and keras.ops.deg2rad to api_master.py, ensuring they are included in the generated documentation. The new entries are correctly placed in alphabetical order. Additionally, the Keras project version in autogen.py has been updated to v3.11.0 to reflect the new release. The changes are correct and align with the stated purpose of the pull request.

Copy link
Collaborator

@sachinprasadhs sachinprasadhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@sachinprasadhs sachinprasadhs merged commit 1d548e4 into keras-team:master Jul 30, 2025
4 checks passed
@shashaka shashaka deleted the ops_api branch July 30, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants