-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add missing NumPy ops layer APIs to keras.ops #2157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @shashaka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've opened this pull request to enhance the keras.ops module by incorporating two previously missing NumPy-like operations: corrcoef and heaviside. This change aims to provide a more comprehensive and consistent set of numerical operations within Keras, making it easier for users to perform common array manipulations directly through keras.ops. The primary impact is the expansion of Keras's built-in functional capabilities, reducing the need to rely on external NumPy calls for these specific operations.
Highlights
- API Expansion: I've added the
keras.ops.corrcoeffunction to thekeras.opsmodule, aligning Keras's operational capabilities more closely with standard NumPy. - API Expansion: I've also added the
keras.ops.heavisidefunction to thekeras.opsmodule, further completing the set of NumPy-like operations available in Keras. - API Listing Update: The
scripts/api_master.pyfile has been updated to include these new operations, ensuring they are properly listed and exposed as part of the Keras API.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two new NumPy ops, corrcoef and heaviside, to the API master list. The change is mostly correct, but keras.ops.heaviside has been added in the wrong alphabetical position. I've left a comment with a suggestion to fix the ordering to maintain consistency within the file.
fchollet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
This PR adds the following missing numpy ops APIs: