Skip to content

Conversation

@sachinprasadhs
Copy link
Collaborator

@sachinprasadhs sachinprasadhs commented Aug 15, 2025

  • Update Keras Hub version
  • Pin Tensorflow and TF-Keras version to avoid circular imports till we have matching TF-Keras version with TF.
  • Updated DinoV2 API doc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @sachinprasadhs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the DINOv2 model components into the Keras Hub framework and updates the Keras Hub version dependency. The changes ensure that the latest DINOv2 models are available and properly documented within the Keras Hub, while also aligning with the most recent Keras Hub library version.

Highlights

  • Keras Hub Version Update: The keras_hub dependency in scripts/autogen.py has been updated from v0.21.1 to v0.22.1, ensuring compatibility with the latest Keras Hub features and models.
  • DINOv2 Model Integration: New entries for DINOv2 models, specifically DINOV2ImageConverter and DINOV2Backbone, have been added to scripts/hub_master.py. This integration enables their generation and documentation within the Keras Hub ecosystem, making them accessible for use.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the DINOv2 model and updates the keras_hub package version. The changes look good, primarily involving additions to configuration files. I have one minor suggestion to improve naming consistency for the new DINOv2 model entry.

sachinprasadhs and others added 3 commits August 15, 2025 13:25
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@sachinprasadhs sachinprasadhs merged commit 8a56c17 into keras-team:master Aug 15, 2025
3 checks passed
@sachinprasadhs sachinprasadhs deleted the dinov2_api branch August 15, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants