Skip to content

Conversation

@hertschuh
Copy link
Contributor

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hertschuh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Keras version reference within the scripts/autogen.py file from 3.11.2 to 3.11.3. This change ensures that internal scripts and documentation links point to the latest stable Keras release.

Highlights

  • Keras Version Update: The Keras version referenced in scripts/autogen.py has been updated from v3.11.2 to v3.11.3.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Keras version to 3.11.3 in the documentation generation script. While the change is straightforward, I've identified an opportunity to improve code maintainability. My feedback suggests refactoring the way project versions are stored, moving them from hardcoded strings within URLs to a centralized configuration dictionary. This will make future version bumps for any of the Keras-related projects simpler and less prone to errors.

KERAS_TEAM_GH = "https://github.com/keras-team"
PROJECT_URL = {
"keras": f"{KERAS_TEAM_GH}/keras/tree/v3.11.2/",
"keras": f"{KERAS_TEAM_GH}/keras/tree/v3.11.3/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change is correct, having version strings hardcoded inside the PROJECT_URL dictionary can make future updates cumbersome and error-prone. To improve maintainability, I'd suggest extracting all project versions into a separate configuration dictionary. This centralizes version management.

For example, you could refactor the entire PROJECT_URL block like this:

PROJECT_VERSIONS = {
    "keras": "v3.11.3",
    "keras_tuner": "v1.4.7",
    "keras_hub": "v0.22.1",
    "tf_keras": "v2.19.0",
    "keras_rs": "v0.2.1",
}

PROJECT_URL = {
    project: f"{KERAS_TEAM_GH}/{project.replace('_', '-')}/tree/{version}/"
    for project, version in PROJECT_VERSIONS.items()
}

@sachinprasadhs sachinprasadhs merged commit 7894001 into keras-team:master Aug 22, 2025
4 checks passed
@hertschuh hertschuh deleted the keras3113 branch August 22, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants