-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add prerequisites section to image classification from scratch example #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add prerequisites section to image classification from scratch example #2223
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @Parshv-sudo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the onboarding experience for the 'Image classification from scratch' example by introducing a clear 'Prerequisites' section. This addition helps users quickly assess their readiness by detailing the necessary foundational knowledge and providing links to relevant Keras documentation. The changes are purely documentation-focused and do not alter any existing code functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a helpful "Prerequisites" section to the "Image classification from scratch" example, which is a great improvement for user onboarding. However, there are a couple of issues in the implementation. In the Jupyter notebook, the new section is incorrectly added as a code cell, leading to a SyntaxError. It should be a markdown cell. In the corresponding Markdown file, the new section is wrapped in """, which is not standard Markdown and will likely render incorrectly. I've provided suggestions to correct these issues and also to improve the formatting of URLs to be consistent with the rest of the documentation.
|
Hi @sachinprasadhs, |
Summary
Adds a short “Prerequisites” section to the Image classification from scratch example,
outlining the expected background knowledge and linking to relevant Keras guides and recipes.
Motivation
Improves onboarding by helping readers assess readiness before diving into the example,
as discussed in #2151.
Scope
Documentation-only change; no code behavior is modified.