-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix: Use secure HTTPS and automatic extraction for MovieLens dataset #2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaytiwarihub
wants to merge
8
commits into
keras-team:master
Choose a base branch
from
jaytiwarihub:fix-movielens-loader
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ba830e5
Fix: Replace manual unzip shell command with Python zipfile
jaytiwarihub e09e613
Fix: Reorder imports to satisfy linter
jaytiwarihub 85896c5
Refactor: Use pathlib for file handling
jaytiwarihub 2099d73
Trigger CLA check
jaytiwarihub d199a2a
Fix: Replace shell commands with Keras pipeline in NLP example
jaytiwarihub cb0d3f9
Fix: Use secure HTTPS and automatic extraction for MovieLens dataset
jaytiwarihub d13dedf
Cleanup: Revert accidental formatting changes to unrelated files
jaytiwarihub d74d283
Docs: Sync notebook with HTTPS fix
jaytiwarihub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ | |
| from pathlib import Path | ||
| import matplotlib.pyplot as plt | ||
| import numpy as np | ||
| from zipfile import ZipFile | ||
|
|
||
|
|
||
| import keras | ||
| from keras import layers | ||
|
|
@@ -48,23 +48,16 @@ | |
|
|
||
| # Download the actual data from http://files.grouplens.org/datasets/movielens/ml-latest-small.zip" | ||
| # Use the ratings.csv file | ||
| # FIX: Use HTTPS and let Keras handle extraction automatically | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can remove this comment. |
||
| movielens_data_file_url = ( | ||
| "http://files.grouplens.org/datasets/movielens/ml-latest-small.zip" | ||
| "https://files.grouplens.org/datasets/movielens/ml-latest-small.zip" | ||
| ) | ||
| movielens_zipped_file = keras.utils.get_file( | ||
| "ml-latest-small.zip", movielens_data_file_url, extract=False | ||
| "ml-latest-small.zip", movielens_data_file_url, extract=True | ||
| ) | ||
| keras_datasets_path = Path(movielens_zipped_file).parents[0] | ||
| movielens_dir = keras_datasets_path / "ml-latest-small" | ||
|
|
||
| # Only extract the data the first time the script is run. | ||
| if not movielens_dir.exists(): | ||
| with ZipFile(movielens_zipped_file, "r") as zip: | ||
| # Extract files | ||
| print("Extracting all the files now...") | ||
| zip.extractall(path=keras_datasets_path) | ||
| print("Done!") | ||
|
|
||
| ratings_file = movielens_dir / "ratings.csv" | ||
| df = pd.read_csv(ratings_file) | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.