Migrated ctc_asr from keras2 to keras3#2262
Migrated ctc_asr from keras2 to keras3#2262sachinprasadhs merged 7 commits intokeras-team:masterfrom
Conversation
Summary of ChangesHello @kharshith-k, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Automatic Speech Recognition (ASR) example, specifically the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates the CTC ASR example from Keras 2 to Keras 3. The changes correctly update the imports and replace deprecated Keras 2 APIs like keras.backend.ctc_decode with their Keras 3 / TensorFlow equivalents.
My review includes several suggestions for improvement:
- Correcting placeholder metadata at the top of the script.
- Removing duplicated markdown links.
- Refactoring a path correction for
wavs_pathto be defined correctly at the beginning of the script, which simplifies the code by removing redundant dataset re-creation. - A minor suggestion to use more idiomatic tensor indexing.
Overall, the migration is well-done, and with these changes, the code will be cleaner and more maintainable.
sachinprasadhs
left a comment
There was a problem hiding this comment.
I have reviewed only .py file as the source of truth, please address the comments and there are still many places where tf ops are used, try. to reduce the dependency, I have added my suggestions to few.
Colab Notebook