Skip to content

add KerasRS video to docs#2281

Open
yufengg wants to merge 1 commit intokeras-team:masterfrom
yufengg:keras-rs-video
Open

add KerasRS video to docs#2281
yufengg wants to merge 1 commit intokeras-team:masterfrom
yufengg:keras-rs-video

Conversation

@yufengg
Copy link
Contributor

@yufengg yufengg commented Feb 6, 2026

need to confirm that it renders okay on the actual website, not just on the github preview

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yufengg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Keras Recommenders documentation by integrating a YouTube video directly into its main index page. The addition of this video aims to provide a more dynamic and engaging resource for users, offering a visual explanation or overview of Keras Recommenders, thereby improving the overall learning experience.

Highlights

  • Video Embedding: A YouTube video embed has been added to the Keras Recommenders documentation page.
  • Interactive Content: The embed features a clickable thumbnail image that links directly to the KerasRS video on YouTube.
  • Styling: The video embed is horizontally centered on the page using inline HTML styling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • templates/keras_rs/index.md
    • Added an HTML block containing a div, a, and img tag to embed a YouTube video.
    • The embedded video is for KerasRS and includes a thumbnail image with a border.
    • The video embed is centered on the page using text-align: center.
Activity
  • The author, yufengg, has indicated that the rendering of the video embed needs to be confirmed on the live website, not just in the GitHub preview.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an embedded YouTube video thumbnail to the Keras Recommenders documentation. The addition is functional, but there are opportunities to improve the HTML structure for better web standards adherence, security, and maintainability.


<div style="text-align: center;">
<a href="http://www.youtube.com/watch?feature=player_embedded&v=uV3gymO9K98&list=PL9f9vdy2ar1IdH6O6kQGn4Ln-_oLH_Ra3"
target="_blank"><img src="http://img.youtube.com/vi/uV3gymO9K98/hqdefault.jpg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The image source uses http instead of https. It's best practice to use https to avoid mixed content warnings and ensure secure connections, especially if the main website is served over HTTPS.

Suggested change
target="_blank"><img src="http://img.youtube.com/vi/uV3gymO9K98/hqdefault.jpg"
target="_blank"><img src="https://img.youtube.com/vi/uV3gymO9K98/hqdefault.jpg"

<div style="text-align: center;">
<a href="http://www.youtube.com/watch?feature=player_embedded&v=uV3gymO9K98&list=PL9f9vdy2ar1IdH6O6kQGn4Ln-_oLH_Ra3"
target="_blank"><img src="http://img.youtube.com/vi/uV3gymO9K98/hqdefault.jpg"
alt="KerasRS Video" width="360" height="270" border="10" /></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The border attribute on the <img> tag is deprecated in HTML5. Styling should be handled using CSS for better separation of concerns and maintainability.

Suggested change
alt="KerasRS Video" width="360" height="270" border="10" /></a>
alt="KerasRS Video" width="360" height="270" /></a>

receive that same level of polish as core Keras. If you are familiar with Keras,
congratulations! You already understand most of Keras Recommenders.

<div style="text-align: center;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using inline styles like style="text-align: center;" is generally discouraged for maintainability and reusability. While it might be necessary in Markdown for quick styling, consider if a CSS class could be applied if there's a global stylesheet to keep styling consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants