List all the missing APIs#2283
Conversation
Summary of ChangesHello @sachinprasadhs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to comprehensively list and expose a broader range of Keras APIs within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request does a great job of adding many missing APIs to the documentation master file. My review focuses on improving the organization and consistency of these new additions, in line with your request for feedback on reorganization. I've suggested refactoring the new 'Core API' and 'layer_utilities' sections to avoid duplication and group related items, and proposed a consistent approach for documenting serialization utility functions across different modules. These changes should help improve the structure and maintainability of the API documentation.
hertschuh
left a comment
There was a problem hiding this comment.
Thanks! They are a number of useful things we should add.
But remove all the aliases.
|
@hertschuh Thanks for the detailed review, I have addressed the remaining comments and marked as resolved. |
Done |
| "keras.quantizers.Int8QuantizationConfig", | ||
| "keras.quantizers.Int4QuantizationConfig", | ||
| "keras.quantizers.Float8QuantizationConfig", | ||
| "keras.quantizers.GPTQConfig", |
There was a problem hiding this comment.
Can you also add keras.quantizers.AWQConfig?
There was a problem hiding this comment.
I guess it's still not part of 3.13
|
Done, reverted the aliases changes. For the aliases logic to work in a different PR or to automate this, there are 2 scenarios we consider as aliases right? Case1: Case 2: Is there any other way we can consider as aliases, especially for ops. |
No, that's it. So case 2 is the one we should document automatically. Case 1 is not a "true" alias. Maybe we should reconsider if we document them (as separate symbols). |

Reverted the below changes, will add this in a separate PR
Below is the sample output for Aliases section:
