fix: correct total_loss calculate assign

[maitry63]

This PR resolves total_loss summing calculation with correct position.

Fixes: #983

Refer this notebook.

[gemini-code-assist]

Summary of Changes

Hello @maitry63, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the vae.py example by correcting the sequence of operations for updating and reporting the total loss within the train_step function. The change ensures that the total loss tracker is updated at the appropriate time and that the 'loss' key is consistently positioned in the method's return dictionary, leading to more accurate and reliable loss reporting during VAE training.

Highlights

• Total Loss Tracking Correction: The update call for self.total_loss_tracker within the train_step method was repositioned to ensure the total loss is tracked at the correct point in the execution flow.
• Return Dictionary Reordering: The 'loss' key in the dictionary returned by the train_step method was reordered to align with the corrected position of the total_loss_tracker update.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• examples/generative/vae.py
  • Reordered the self.total_loss_tracker.update_state call to a later point in the train_step method.
  • Adjusted the position of the 'loss' key in the dictionary returned by train_step.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the train_step method in the VAE example by reordering the metric updates and the keys in the returned dictionary. While this is a good stylistic improvement, there's an opportunity to improve consistency. I've added a specific comment to align the name of the returned loss metric with its definition.

[jeffcarp]

Thanks!