Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

fix support for numpy mmap backend (np.memmap)#200

Open
nicolaerosia wants to merge 1 commit intokeras-team:masterfrom
nicolaerosia:np-memmap-support
Open

fix support for numpy mmap backend (np.memmap)#200
nicolaerosia wants to merge 1 commit intokeras-team:masterfrom
nicolaerosia:np-memmap-support

Conversation

@nicolaerosia
Copy link

@nicolaerosia nicolaerosia commented Apr 18, 2019

Summary

ImageDataGenerator.flow needs to create an NumpyArrayIterator
which honors the input's dtype.
NumpyArrayIterator needs to use numpy.asanyarray to work with numpy.memmap.

Related Issues

PR Overview

  • [N] This PR requires new unit tests [y/n] (make sure tests are included)
  • [N] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • [Y] This PR is backwards compatible [y/n]
  • [N] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

@nicolaerosia
fix support for numpy mmap backend (np.memmap)
0c12b0a 
ImageDataGenerator.flow needs to create an NumpyArrayIterator
which honors the input's dtype.
NumpyArrayIterator needs to use numpy.asanyarray to work with numpy.memmap.

Signed-off-by: Nicolae Rosia <nicolae.rosia@gmail.com>
@Dref360
Copy link
Contributor

Dref360 commented Apr 18, 2019

This PR requires new unit tests.

@nicolaerosia
Copy link
Author

nicolaerosia commented Apr 18, 2019

I missed this one, Numpy array of rank 4 or a tuple.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolaerosia @Dref360