Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion keras/src/losses/losses.py
Original file line number Diff line number Diff line change
Expand Up @@ -1972,7 +1972,9 @@ def huber(y_true, y_pred, delta=1.0):
delta = ops.convert_to_tensor(delta, dtype=y_pred.dtype)
error = ops.subtract(y_pred, y_true)
abs_error = ops.abs(error)
half = ops.convert_to_tensor(0.5, dtype=abs_error.dtype)
half = ops.cast(ops.convert_to_tensor(0.5), dtype=abs_error.dtype)
delta = ops.cast(delta, dtype=abs_error.dtype)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This explicit cast on delta is redundant. On line 1972, delta is already converted to a tensor with y_pred.dtype. Since abs_error.dtype is the same as y_pred.dtype (as it's derived from y_pred and y_true), this line is effectively a no-op (ops.cast(delta, delta.dtype)). You can safely remove this line to avoid the unnecessary operation.


return ops.mean(
ops.where(
abs_error <= delta,
Expand Down
34 changes: 34 additions & 0 deletions keras/src/losses/losses_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,40 @@ def test_dtype_arg(self):
loss = h_obj(self.y_true, self.y_pred)
self.assertDType(loss, "bfloat16")

def test_huber_memory_usage_debug_05(self):
import tensorflow as tf

import keras

print("\n[Huber GPU Memory Debug: delta=0.5]")
gpus = tf.config.experimental.list_physical_devices("GPU")
if not gpus:
print("No GPU found. Skipping test.")
return
try:
for gpu in gpus:
tf.config.experimental.set_memory_growth(gpu, True)
except RuntimeError as e:
print(f"[Info] GPU memory growth already set or initialized: {e}")

x = np.random.rand(1000, 1)
y = ((3 * x) + 2) + np.random.randn(1000, 1)
huber_loss = keras.losses.Huber(delta=0.5)
loss = huber_loss(y, x)
print(f"Huber loss: {loss.numpy():.6f}")

memory = sum(
tf.config.experimental.get_memory_info(f"GPU:{i}")["current"]
for i in range(len(gpus))
)
print(f"GPU memory usage: {memory} bytes")

# sanity check for stable GPU usage (adjust threshold as needed)
assert memory > 0, (
f"GPU memory not allocated or usage is zero. "
f"Current usage: {memory} bytes"
)


class LogCoshTest(testing.TestCase):
def setup(self):
Expand Down