Adds Data Handling section to the README#78
Conversation
Removed Pulumi CLI requirement from prerequisites and updated the cleanup section. Pulumi is auto-installed on first run, and users need not install it manually.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the user experience by clarifying the installation and cleanup processes. It removes the need for users to manually install the Pulumi CLI, as it is now automatically handled, and simplifies the description of resource cleanup by removing redundant mentions of Pulumi. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to improve the user experience. It correctly removes the manual installation requirement for the Pulumi CLI, as it is now automatically installed on the first run. It also removes a reference to Pulumi in the resource cleanup section, which aligns with the project's goal of hiding implementation details from the user. The changes are accurate and improve the clarity of the documentation.
Note: Security Review has been skipped due to the limited scope of the PR.
|
|
||
| Keras Remote provides a declarative and performant Data API to seamlessly make your local and cloud data available to your remote functions. | ||
|
|
||
| The Data API is designed to be read-only. It reliably delivers data to your pods at the start of a job. For saving model outputs or checkpointing, you should write directly to GCS from within your function. |
There was a problem hiding this comment.
Should we provide guidance on where in GCS to write? Or leave it completely up to the user?
There was a problem hiding this comment.
I think it's okay to leave it to the user since we don't really have any framework specific guidance to provide at this stage.
|
|
||
| The simplest and most Pythonic approach is to pass `Data` objects as regular function arguments. The `Data` class wraps a local file/directory path or a Google Cloud Storage (GCS) URI. | ||
|
|
||
| On the remote pod, these objects are automatically resolved into plain string paths pointing to the downloaded files, meaning your function code never needs to know about GCS or cloud storage APIs. |
DataandvolumesAPIs.