Sets min_nodes to 0 multi-host configs

[JyotinderSingh]

We need to set min_nodes=0 when provisioning multi-host TPU slices since autoscaling is enabled.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the provisioning logic for TPU node pools by adjusting the minimum node count. The change ensures that multi-host TPU slices, when configured with autoscaling, correctly allow for scaling down by setting the minimum number of nodes to zero, aligning with best practices for elastic resource management.

Highlights

• TPU Configuration: Modified the _create_tpu_node_pool function to unconditionally set min_nodes to 0, ensuring proper autoscaling behavior for multi-host TPU slices.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• keras_remote/cli/infra/program.py
  • Updated the logic for determining min_nodes in TPU node pool creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request correctly updates the _create_tpu_node_pool function to unconditionally set min_nodes to 0. This change aligns with the goal of enabling scale-to-zero for TPU node pools when autoscaling is enabled, which is a good practice for cost optimization and resource management. While the PR description specifically mentions multi-host configurations, the change correctly applies to all TPU node pools, ensuring consistent autoscaling behavior. It is important to ensure that corresponding unit tests are updated to reflect this new behavior, as the previous logic for min_nodes has been altered.