This change proactively relaxes floating point comparisons in unit tests to avoid breaking them when updating the Eigen library in cl/747497592. #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…sts to avoid breaking them when updating the Eigen library in cl/747497592.
Background: The Eigen update contains a number of improvements to the use of fused-multiply-and-add instructions for both float, bfloat16, and float16, as well as changes that may alter summation order in matrix multiplication. While such changes only cause minor numerical changes locally (relative changes on the order of 2^-23, 2^-10, 2^-7, for float, float16, and bfloat16, respectively), such changes may cause sensitive ("ill-conditioned") computations to deviate more significantly, as those small changes propagate.
PiperOrigin-RevId: 748177632
copybara-service
bot
force-pushed
the
test_747920741
branch
from
593a224 to
02448f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change proactively relaxes floating point comparisons in unit tests to avoid breaking them when updating the Eigen library in cl/747497592.
Background: The Eigen update contains a number of improvements to the use of fused-multiply-and-add instructions for both float, bfloat16, and float16, as well as changes that may alter summation order in matrix multiplication. While such changes only cause minor numerical changes locally (relative changes on the order of 2^-23, 2^-10, 2^-7, for float, float16, and bfloat16, respectively), such changes may cause sensitive ("ill-conditioned") computations to deviate more significantly, as those small changes propagate.