bpf: Fix NULL pointer dereference in bpf_skb_fib_lookup()#11873
Closed
kernel-patches-daemon-bpf[bot] wants to merge 1 commit into
Closed
bpf: Fix NULL pointer dereference in bpf_skb_fib_lookup()#11873kernel-patches-daemon-bpf[bot] wants to merge 1 commit into
kernel-patches-daemon-bpf[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: eb5249b |
Author
|
Upstream branch: eb5249b |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1082997=>bpf
branch
from
0100d55 to
cf4a097
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf_base
branch
from
ae206c0 to
495374b
Compare
When tot_len is not provided by the user, bpf_skb_fib_lookup() resolves the FIB result's output device via dev_get_by_index_rcu() to check skb forwardability and fill in mtu_result. The returned pointer is dereferenced without a NULL check. If the device is concurrently unregistered, dev_get_by_index_rcu() returns NULL and is_skb_forwardable() crashes at dev->flags: KASAN: null-ptr-deref in range [0x00000000000000b0-0x00000000000000b7] Call Trace: is_skb_forwardable (include/linux/netdevice.h:4365) bpf_skb_fib_lookup (net/core/filter.c:6446) bpf_prog_test_run_skb (net/bpf/test_run.c) __sys_bpf (kernel/bpf/syscall.c) Add the missing NULL check, returning -ENODEV to be consistent with how bpf_ipv4_fib_lookup() and bpf_ipv6_fib_lookup() handle the same condition. Fixes: e1850ea ("bpf: bpf_fib_lookup return MTU value as output when looked up") Reported-by: Xiang Mei <xmei5@asu.edu> Signed-off-by: Weiming Shi <bestswngs@gmail.com> Acked-by: Paul Chaignon <paul.chaignon@gmail.com>
Author
|
Upstream branch: cd0eb48 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1082997=>bpf
branch
from
cf4a097 to
e9bda7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Fix NULL pointer dereference in bpf_skb_fib_lookup()
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1082997