xskmap: reject TX-only AF_XDP sockets#11974
Closed
kernel-patches-daemon-bpf[bot] wants to merge 1 commit into
Closed
xskmap: reject TX-only AF_XDP sockets#11974kernel-patches-daemon-bpf[bot] wants to merge 1 commit into
kernel-patches-daemon-bpf[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: cfeddb4 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
d63a9bb to
6d81208
Compare
Author
|
Upstream branch: 9f5b3ff |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1086843=>bpf-next
branch
from
7142ee6 to
138a800
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
6d81208 to
e299921
Compare
Author
|
Upstream branch: 2ca6723 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1086843=>bpf-next
branch
from
138a800 to
6381aad
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
e299921 to
68b493c
Compare
Author
|
Upstream branch: 2ca6723 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1086843=>bpf-next
branch
from
6381aad to
7d353cb
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf-next_base
branch
from
68b493c to
149211d
Compare
Author
|
Upstream branch: 2ca6723 |
XSKMAP entries are used as redirect targets for incoming XDP frames. A TX-only AF_XDP socket lacks an Rx ring and cannot handle redirected traffic, but xsk_map_update_elem() currently allows such sockets to be inserted into the map. Redirecting packets to such a socket on the veth generic-XDP path causes a kernel crash in xsk_generic_rcv(). This became possible after xsk_is_setup_for_bpf_map() was removed from the XSKMAP update path, which allowed bound TX-only sockets to be inserted into the map. Reject TX-only sockets during XSKMAP updates to avoid the crash. They remain fully operational for pure Tx purposes outside XSKMAP. Fixes: 968be23 ("xsk: Fix possible segfault at xskmap entry insertion") Reported-by: Juefei Pu <tomapufckgml@gmail.com> Reported-by: Yuan Tan <yuantan098@gmail.com> Reported-by: Xin Liu <bird@lzu.edu.cn> Signed-off-by: Yifan Wu <yifanwucs@gmail.com> Signed-off-by: Linpu Yu <linpu5433@gmail.com>
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1086843=>bpf-next
branch
from
7d353cb to
471ec17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: xskmap: reject TX-only AF_XDP sockets
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1086843