bpf: Don't run arg-tracking analysis twice on main subprog#12032
Closed
kernel-patches-daemon-bpf[bot] wants to merge 2 commits intobpf_basefrom
Closed
bpf: Don't run arg-tracking analysis twice on main subprog#12032kernel-patches-daemon-bpf[bot] wants to merge 2 commits intobpf_basefrom
kernel-patches-daemon-bpf[bot] wants to merge 2 commits intobpf_basefrom
Conversation
Author
|
Upstream branch: 0c7ae13 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf_base
branch
from
ee9631b to
010a7e6
Compare
Author
|
Upstream branch: f3b8c28 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1091222=>bpf
branch
from
d2061f1 to
2660fef
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf_base
branch
from
010a7e6 to
c40937c
Compare
Author
|
Upstream branch: 18fc650 |
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1091222=>bpf
branch
from
2660fef to
db7a0f0
Compare
Author
|
Upstream branch: 18fc650 |
Because subprog 0, the main subprog, is considered a global function, we end up running the arg-tracking dataflow analysis twice on it. That results in slightly longer verification but mostly in more verbose verifier logs. This patch fixes it by keeping only the iteration over global subprogs. When running over all of Cilium's programs with BPF_LOG_LEVEL2, this reduces verbosity by ~20% on average. Fixes: bf0c571 ("bpf: introduce forward arg-tracking dataflow analysis") Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com> Acked-by: Eduard Zingerman <eddyz87@gmail.com>
kernel-patches-daemon-bpf
Bot
force-pushed
the
series/1091222=>bpf
branch
from
db7a0f0 to
f6c515e
Compare
kernel-patches-daemon-bpf
Bot
force-pushed
the
bpf_base
branch
from
c40937c to
bc609a5
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1091222 irrelevant now. Closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Don't run arg-tracking analysis twice on main subprog
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1091222