Skip to content

Conversation

@spbnick
Copy link
Collaborator

@spbnick spbnick commented Jun 6, 2024

No description provided.

@spbnick spbnick force-pushed the support_v4_4_schema branch from 9118b53 to 4816023 Compare June 6, 2024 08:24
@spbnick
Copy link
Collaborator Author

spbnick commented Jun 6, 2024

@hardboprobot, here's the preliminary support for our draft v4.4 I/O schema. Deployment tests are still running, but it should be sufficient to create a database, and start submitting "transitions". We can make a development/test deployment in staging for us to play with. We can start with generating the transitions using SQL directly, and then see whether we can/need to implement the ORM support for it.

Please review!

@spbnick
Copy link
Collaborator Author

spbnick commented Jun 6, 2024

This attempts to separate the "dummy" support for the schema from the actual database support. However, I haven't tested yet if it would work. Will do that later.

@r-c-n r-c-n self-requested a review June 6, 2024 14:21
r-c-n
r-c-n previously approved these changes Jun 6, 2024
Copy link

@r-c-n r-c-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are so many things here I'm not familiar with that I can't really say anything other than if you're ok with the changes and they're tested and work, then it's fine by me. I like the plan, let me know when I can jump in to play with transitions and detections.

@spbnick
Copy link
Collaborator Author

spbnick commented Jun 6, 2024

There are so many things here I'm not familiar with that I can't really say anything other than if you're ok with the changes and they're tested and work, then it's fine by me. I like the plan, let me know when I can jump in to play with transitions and detections.

No problem! I just wanted you to take a look to get a feel for it, and tell me if you spotted anything weird.

Would you like to have a call and go over how to do a deployment, get a data sample, load it up, and so on? Or would you prefer I do all that for you and just give you the database credentials?

In any case once you've got a feel for the schema and tried implementing the analysis, we can get on with implementing it in KCIDB. As a hardcoded function, for example, for the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants