fix(frontend): Backfill SELECT input override from trigger (#10627) #11943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#10627) Fixes an issue where 'SELECT' type inputs defined in a scheduled trigger were ignored during backfill, causing the flow to use the default flow input instead of the trigger's input value. The bug was in the frontend (FlowRun.vue) where the execution payload was not merging the inputs correctly. The fix ensures that: - Inputs from the trigger (`this.selectedTrigger.inputs`) are included in the payload. - The user's final selection from the modal (`this.inputsNoDefaults`) always overrides the trigger's default, using the spread operator logic: inputs: this.selectedTrigger?.inputs ? { ...this.selectedTrigger.inputs, ...this.inputsNoDefaults } : this.inputsNoDefaults,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the bug where 'SELECT' type inputs configured in a scheduled trigger were ignored during backfill executions, causing the flow to use the default flow input instead of the trigger's input value.
The fix is applied in the frontend logic (
FlowRun.vue) and ensures that:this.selectedTrigger.inputs(the trigger's defaults) with the user's final selection (this.inputsNoDefaults).Closes #10627