feat(ui): add safe HTML preview for .html artifacts in execution drawer (#5332) #11949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are being made and why?
Summary
Implementation
ui/src/components/executions/outputs/HtmlPreview.vue
sandbox="allow-scripts"
(noallow-same-origin
),referrerpolicy="no-referrer"
.html
/.htm
by extension.<HtmlPreview :downloadUrl="..." />
and hides the non-relevant controls for HTML.Value
How the changes have been QAed?
Acceptance checks
Example flow to exercise HTML preview
Local checks run
npm run test: unit
– passed.npm run test:e2e
– passed (with one scenario skipped as in current repo baseline).npm run test: lint
– no errors in touched files (some repo-wide warnings pre-existing).Setup Instructions
No special setup required. This is a UI-only change; backend and plugins are unchanged.