-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(core): allow null val for optional input with default (#11819) #11960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Handles multipart 'null' string as null (no value) for the input Fixes: #11819
🐋 Docker image
docker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:11960 server local 🧪 Java Unit Tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced here as now a String input with the string "null"
would be considered a null input which seems wrong to me and is clearly a BC.
A null input should not have any part.
Tests report quick summary:totals > tests: 3425, success: 3412, skipped: 13, failed: 0
Flaky tests report quick summary:totals > tests: 22, success: 17, skipped: 2, failed: 3
Failed tests:core > io.kestra.plugin.core.flow.PauseTest > delayFromInput() failed ❌ in 0.079
core > io.kestra.plugin.core.flow.PauseTest > parallelDelay() failed ❌ in 0.044
core > io.kestra.plugin.core.flow.PauseTest > delay() failed ❌ in 0.053
|
Handles multipart 'null' string as null (no value) for the input
Fixes: #11819