-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix webhook requiring basicauth #11963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
🐋 Docker image
docker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:11963 server local 🧪 Java Unit Tests
|
Tests report quick summary:totals > tests: 3352, success: 3338, skipped: 12, failed: 2
Failed tests:webserver > io.kestra.webserver.controllers.api.MiscControllerTest > canTriggerAWebhookWithoutBasicAuth() failed ❌ in 0.093
webserver > io.kestra.webserver.services.BasicAuthServiceTest > basicAuthAPICreation_shouldNot_discardYamlConfiguration() failed ❌ in 0.022
Flaky tests report quick summary:totals > tests: 22, success: 15, skipped: 2, failed: 5
Failed tests:core > io.kestra.plugin.core.flow.PauseTest > delay() failed ❌ in 0.077
core > io.kestra.plugin.core.flow.PauseTest > parallelDelay() failed ❌ in 0.070
core > io.kestra.plugin.core.flow.PauseTest > delayFromInput() failed ❌ in 0.076
jdbc-mysql > io.kestra.runner.mysql.MysqlServiceLivenessCoordinatorTest > shouldReEmitTasksWhenWorkerIsDetectedAsNonResponding() failed ❌ in 13.921
jdbc-postgres > io.kestra.schedulers.postgres.PostgresSchedulerScheduleTest > recoverNONELongRunningExecution() failed ❌ in 35.108
|
e248490
to
885db3c
Compare
- fixes kestra-io/kestra-ee#5416 The issue was that BasicAuthConfiguration.openUrls was discarded by mistake after a basic auth creds creation
885db3c
to
87b96df
Compare
Tests report quick summary:totals > tests: 3424, success: 3412, skipped: 12, failed: 0
Flaky tests report quick summary:totals > tests: 22, success: 15, skipped: 2, failed: 5
Failed tests:core > io.kestra.plugin.core.flow.PauseTest > delay() failed ❌ in 0.077
core > io.kestra.plugin.core.flow.PauseTest > parallelDelay() failed ❌ in 0.070
core > io.kestra.plugin.core.flow.PauseTest > delayFromInput() failed ❌ in 0.076
jdbc-mysql > io.kestra.schedulers.mysql.MysqlSchedulerScheduleTest > recoverNONELongRunningExecution() failed ❌ in 35.646
jdbc-postgres > io.kestra.schedulers.postgres.PostgresSchedulerScheduleTest > recoverNONELongRunningExecution() failed ❌ in 35.108
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
} | ||
|
||
public void createBasicAuthCredentials(MiscController.BasicAuthCredentials basicAuthCredentials){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make a pojo for this MiscController.BasicAuthCredentials
It might be not enough for existing instances 🤔 |
Uh oh!
There was an error while loading. Please reload this page.