Skip to content

Conversation

elevatebart
Copy link
Contributor

And fix loading of icons

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR converts the plugins store from Pinia's Options API to the Composition API format and fixes icon loading functionality. The refactor maintains the same external interface while modernizing the internal implementation.

Key changes:

  • Converted from Options API (state/getters/actions) to Composition API (ref/computed/functions)
  • Split icon management into separate apiIcons and pluginsIcons refs with a computed icons property
  • Replaced this.$http with the useAxios composable for HTTP requests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

github-actions bot commented Oct 13, 2025

🐋 Docker image

ghcr.io/kestra-io/kestra-pr:11965
docker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:11965 server local

Copy link
Contributor

@Piyush-r-bhaskar Piyush-r-bhaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To review

Development

Successfully merging this pull request may close these issues.

2 participants