fix: only disable initial load if restore URL triggers a query parameter change#16575
Open
Sumitsh28 wants to merge 1 commit into
Open
fix: only disable initial load if restore URL triggers a query parameter change#16575Sumitsh28 wants to merge 1 commit into
Sumitsh28 wants to merge 1 commit into
Conversation
…ter change Signed-off-by: Sumit Shandillya <sumit.off28@gmail.com>
MilosPaunovic
added
area/frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
This PR fixes a bug in
useRestoreUrl.tsthat caused list pages (such as Triggers) to hang indefinitely with a loading spinner when navigating to them.Previously, if a user's
sessionStoragecontained an "empty" filter state (e.g.,{"q": ""}or{"labels": []}),useRestoreUrlwould eagerly abort the initial data fetch. However, because the restored state didn't actually require a URL change, the expected route update never occurred, leaving the data table stuck waiting for a signal that would never arrive. Refreshing the page wouldn't fix it becausesessionStoragesurvives reloads.🔗 Related Issue
Closes #16073
🎨 Frontend Checklist
npm run build)npm run test:e2e)UIchanges