fix(dashboards): improve active tab contrast in Executions card#16647
Open
flcarre wants to merge 1 commit into
Open
fix(dashboards): improve active tab contrast in Executions card#16647flcarre wants to merge 1 commit into
flcarre wants to merge 1 commit into
Conversation
Use --ks-text-inactive (lighter/more muted) instead of --ks-text-secondary for inactive quick-filter tabs, creating a clearer visual distinction between active and inactive states. Add an intermediate font-weight: 500 on hover. Closes kestra-io/kestra-ee#8411
Contributor
🐋 Docker imagedocker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:16647 server local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ks-text-secondary(#5f5f7c in light mode) to--ks-text-inactive(#7e7e9b) — a lighter, more muted token that clearly communicates the inactive state.font-weightfrom 500 → 400, and addedfont-weight: 500on hover as an intermediate visual step.--ks-text-inactivetoken is compliant.Closes https://github.com/kestra-io/kestra-ee/issues/8411
Test Coverage
Tests: unchanged (no new code paths).
Pre-Landing Review
No issues found. Diff is 5 lines of pure CSS — design token swap + font-weight tuning.
Design Review
Design Review: No issues found.
--ks-text-inactive(valid--ks-*semantic token for inactive UI elements).:deep(), no!important, no SCSS variables in feature code.font-weightuses numeric values (correct — no--ks-*font-weight tokens exist).Adversarial Review
All findings were pre-existing code unrelated to this diff. The one finding touching our change (lower contrast on inactive text) is intentional and WCAG-compliant (SC 1.4.3 inactive-UI exemption).
Recommendation: Ship as-is.
Test plan
🤖 Generated with Claude Code