test(worker): mark AbstractGrpcMetaStoreTest as @FlakyTest#16649
Open
AcevedoR wants to merge 1 commit into
Open
test(worker): mark AbstractGrpcMetaStoreTest as @FlakyTest#16649AcevedoR wants to merge 1 commit into
AcevedoR wants to merge 1 commit into
Conversation
GrpcWorkerNamespaceMetaStoreTest intermittently fails in CI with
'Failed to bind to address 0.0.0.0:49646' (and possibly other ports).
Root cause: multiple subclasses of AbstractGrpcMetaStoreTest in the
same module can share a Micronaut test context (same configuration →
same cached context). The shared context evaluates ${random.port} once.
When one class stops the controller in @afterall and another restarts it
in @BeforeAll, the OS port may still be in TIME_WAIT causing a bind
failure on the same port.
Adding @FlakyTest to the abstract base covers all subclasses in both
OSS (worker) and EE (worker-ee) via JUnit 5 annotation inheritance.
Contributor
Tests report quick summary:success ✅ > tests: 6799, success: 6779, skipped: 20, failed: 0 unfold for details
Develocity build scan: https://develocity.kestra.io/s/lc6h45o57qpfe Flaky tests report quick summary:failed ❌ > tests: 14, success: 11, skipped: 0, failed: 3
Failed tests:jdbc-mysql > io.kestra.runner.mysql.MysqlRunnerRetryTest > retryWithFlowableErrors(Execution) failed ❌ in 9.563script > io.kestra.plugin.scripts.runner.docker.DockerTest > interruptAfterResume() failed ❌ in 11.447webserver > io.kestra.webserver.controllers.api.MiscControllerTest > canTriggerAWebhookWithoutBasicAuth() failed ❌ in 30.479 |
Contributor
🧪 Java Unit Tests
🐋 Docker imagedocker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:16649 server local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GrpcWorkerNamespaceMetaStoreTestand siblings fail intermittently in CI with:AbstractGrpcMetaStoreTestsubclasses in the same module can share a Micronaut test context (same configuration = same cached context). The shared context evaluates${random.port}once. When one class stops the controller in@AfterAlland another restarts it in@BeforeAll, the OS port may still be inTIME_WAITcausing a bind failure on the same port.@FlakyTestto the abstract base covers all subclasses in both OSS (worker) and EE (worker-ee) via JUnit 5 annotation inheritance.Test plan