fix(blueprints): missing required param "kind" and dead v-ks-loading on TopNavBar#16652
Open
MilosPaunovic wants to merge 1 commit into
Open
fix(blueprints): missing required param "kind" and dead v-ks-loading on TopNavBar#16652MilosPaunovic wants to merge 1 commit into
MilosPaunovic wants to merge 1 commit into
Conversation
… TopNavBar goBack() navigated to the blueprints route without the required :kind param, causing a Vue Router error "Missing required param kind". Also removes v-ks-loading from <TopNavBar> (fragment root — directive has no effect there; loading is already handled by the <section> below). Closes kestra-io/kestra-ee#8444.
Contributor
🐋 Docker imagedocker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:16652 server local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goBack()inBlueprintDetail.vuenavigated to theblueprintsroute without the required:kindparam, causing Vue Router to throw "Missing required param kind" and crash the<RouterLink>render in the breadcrumbv-ks-loading="!blueprint"from<TopNavBar>— directives don't work on components with fragment roots; the loading state is already correctly handled byv-ks-loadingon the<section>belowCompanion PR in kestra-ee: https://github.com/kestra-io/kestra-ee/pull/8445.
Closes https://github.com/kestra-io/kestra-ee/issues/8444.
Test plan
/blueprints/flow/community/<id>) — no "Missing required param" console error