fix(tests): update WorkerJobFetcherBackoffTest to match new constructor signature#16654
Open
AcevedoR wants to merge 1 commit into
Open
fix(tests): update WorkerJobFetcherBackoffTest to match new constructor signature#16654AcevedoR wants to merge 1 commit into
AcevedoR wants to merge 1 commit into
Conversation
…or signature WorkerJobFetcher gained a GrpcConfiguration parameter but WorkerJobFetcherBackoffTest was not updated, causing a compile error that blocked CI. Add a mock for the new parameter so the test compiles and passes.
Contributor
Tests report quick summary:success ✅ > tests: 6859, success: 6839, skipped: 20, failed: 0 (🔄 6859 executed, 📦 0 from cache) unfold for details
Develocity build scan: https://develocity.kestra.io/s/aj45lekxpbh2q Flaky tests report quick summary:failed ❌ > tests: 14, success: 11, skipped: 0, failed: 3
Failed tests:jdbc-mysql > io.kestra.runner.mysql.MysqlRunnerRetryTest > retryWithFlowableErrors(Execution) failed ❌ in 8.375script > io.kestra.plugin.scripts.runner.docker.DockerTest > interruptAfterResume() failed ❌ in 11.880webserver > io.kestra.webserver.controllers.api.MiscControllerTest > canTriggerAWebhookWithoutBasicAuth() failed ❌ in 30.646 |
Contributor
🧪 Java Unit Tests
🐋 Docker imagedocker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:16654 server local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkerJobFetchergained aGrpcConfigurationparameter in a recent commit butWorkerJobFetcherBackoffTestwas not updated, causing a compile error (required 7 args, found 6) that blocks the entireworker:compileTestJavatask — breaking both OSS and kestra-ee CI ondevelop.mock(GrpcConfiguration.class)as the 7th constructor argumentTest plan
./gradlew :worker:compileTestJava --rerun-taskspasses locally with no errors