Skip to content

feat: added max files limit#683

Merged
fdelbrayelle merged 3 commits intokestra-io:mainfrom
bishalbera:feat-add-default-limit
Jan 30, 2026
Merged

feat: added max files limit#683
fdelbrayelle merged 3 commits intokestra-io:mainfrom
bishalbera:feat-add-default-limit

Conversation

@bishalbera
Copy link
Contributor

closes 14276

@github-project-automation github-project-automation bot moved this to To review in Pull Requests Jan 27, 2026
@bishalbera
Copy link
Contributor Author

Screenshot 2026-01-27 at 11 46 21 AM Screenshot 2026-01-27 at 11 46 05 AM
tasks:
  - id: list_exceeds_limit
    type: io.kestra.plugin.aws.s3.List
    accessKeyId: test
    secretKeyId: test
    region: us-east-1
    endpointOverride: http://172.17.0.2:4566
    bucket: test-bucket
    prefix: "test-dir/"
    maxFiles: 2

  - id: list_within_limit
    type: io.kestra.plugin.aws.s3.List
    accessKeyId: test
    secretKeyId: test
    region: us-east-1
    endpointOverride: http://172.17.0.2:4566
    bucket: test-bucket
    prefix: "test-dir/"
    maxFiles: 10

  - id: downloads_exceeds_limit
    type: io.kestra.plugin.aws.s3.Downloads
    accessKeyId: test
    secretKeyId: test
    region: us-east-1
    endpointOverride: http://172.17.0.2:4566
    bucket: test-bucket
    prefix: "test-dir/"
    maxFiles: 2

  - id: downloads_within_limit
    type: io.kestra.plugin.aws.s3.Downloads
    accessKeyId: test
    secretKeyId: test
    region: us-east-1
    endpointOverride: http://172.17.0.2:4566
    bucket: test-bucket
    prefix: "test-dir/"
    maxFiles: 10

  - id: download_exceeds_limit
    type: io.kestra.plugin.aws.s3.Download
    accessKeyId: test
    secretKeyId: test
    region: us-east-1
    endpointOverride: http://172.17.0.2:4566
    bucket: test-bucket
    prefix: "test-dir/"
    maxFiles: 2

  - id: download_within_limit
    type: io.kestra.plugin.aws.s3.Download
    accessKeyId: test
    secretKeyId: test
    region: us-east-1
    endpointOverride: http://172.17.0.2:4566
    bucket: test-bucket
    prefix: "test-dir/"
    maxFiles: 10

@bishalbera
Copy link
Contributor Author

@fdelbrayelle please check this when you've time :)

@MilosPaunovic MilosPaunovic requested review from a team and fdelbrayelle January 27, 2026 07:06
@MilosPaunovic MilosPaunovic added area/plugin Plugin-related issue or feature request kind/external Pull requests raised by community contributors labels Jan 27, 2026
@bishalbera
Copy link
Contributor Author

Please check now @fdelbrayelle :)

@fdelbrayelle fdelbrayelle changed the title feat: added max files limit feat!: BREAKING CHANGE - added max files limit Jan 30, 2026
@fdelbrayelle
Copy link
Member

Hi and thanks @bishalbera 👋 Since this is breaking change, could you squash your commits and rename it to feat!: BREAKING CHANGE - added max files limit please 🙏?

@bishalbera
Copy link
Contributor Author

check now @fdelbrayelle

@fdelbrayelle fdelbrayelle changed the title feat!: BREAKING CHANGE - added max files limit feat: added max files limit Jan 30, 2026
Copy link
Member

@fdelbrayelle fdelbrayelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Biblap! 👍

@bishalbera
Copy link
Contributor Author

bishalbera commented Jan 30, 2026

Thanks Biblap! 👍

Most welcome 🖤 . So now I'm raising the other pr. should I set the title and commit as feat!: BREAKING CHANGE - added max files limit @fdelbrayelle

@fdelbrayelle
Copy link
Member

Wait @bishalbera I'm merging then you can create a PR with 1 commit with the breaking change in it yes please 🙏

@fdelbrayelle fdelbrayelle merged commit 89d1708 into kestra-io:main Jan 30, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from To review to Done in Pull Requests Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/plugin Plugin-related issue or feature request kind/external Pull requests raised by community contributors

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add safe default limits to plugin-aws

3 participants