Skip to content

build(deps): bump + migrate deps (sbm)#250

Draft
Malaydewangan09 wants to merge 1 commit intomainfrom
bump/jcifs
Draft

build(deps): bump + migrate deps (sbm)#250
Malaydewangan09 wants to merge 1 commit intomainfrom
bump/jcifs

Conversation

@Malaydewangan09
Copy link
Member

What changes are being made and why?


How the changes have been QAed?


Setup Instructions


Contributor Checklist ✅

  • PR Title and commits follows conventional commits
  • Add a closes #ISSUE_ID or fixes #ISSUE_ID in the description if the PR relates to an opened issue.
  • Documentation updated (plugin docs from @Schema for properties and outputs, @Plugin with examples, README.md file with basic knowledge and specifics).
  • Setup instructions included if needed (API keys, accounts, etc.).
  • Prefix all rendered properties by r not rendered (eg: rHost).
  • Use runContext.logger() to log enough important infos where it's needed and with the best level (DEBUG, INFO, WARN or ERROR).

⚙️ Properties

  • Properties are declared with Property<T> carrier type, do not use @PluginProperty.
  • Mandatory properties must be annotated with @NotNull and checked during the rendering.
  • You can model a JSON thanks to a simple Property<Map<String, Object>>.

🌐 HTTP

  • Must use Kestra’s internal HTTP client from io.kestra.core.http.client

📦 JSON

  • If you are serializing response from an external API, you may have to add a @JsonIgnoreProperties(ignoreUnknown = true) at the mapped class level. So that we will avoid to crash the plugin if the provider add a new field suddenly.
  • Must use Jackson mappers provided by core (io.kestra.core.serializers)

New plugins / subplugins

  • Make sure your new plugin is configured like mentioned here.
  • Add a package-info.java under each sub package respecting this format and choosing the right category.
  • Icons added in src/main/resources/icons in SVG format and not in thumbnail (keep it big):
    • plugin-icon.svg
    • One icon per package, e.g. io.kestra.plugin.aws.svg
    • For subpackages, e.g. io.kestra.plugin.aws.s3, add io.kestra.plugin.aws.s3.svg
      See example here.
  • Use "{{ secret('YOUR_SECRET') }}" in the examples for sensible infos such as an API KEY.
  • If you are fetching data (one, many or too many), you must add a Property<FetchType> fetchType to be able to use FETCH_ONE, FETCH and even STORE to store big amount of data in the internal storage.
  • Align the """ to close examples blocks with the flow id.

🧪 Tests

  • Unit Tests added or updated to cover the change (using the RunContext to actually run tasks).
  • Add sanity checks if possible with a YAML flow inside src/test/resources/flows.
  • Avoid disabling tests for CI. Instead, configure a local environment whenever it's possible with .github/setup-unit.sh (which can be executed locally and in the CI) all along with a new docker-compose-ci.yml file (do not edit the existing docker-compose.yml).
  • Provide screenshots from your QA / tests locally in the PR description. The goal here is to use the JAR of the plugin and directly test it locally in Kestra UI to ensure it integrates well.

📤 Outputs

  • Do not send back as outputs the same infos you already have in your properties.
  • If you do not have any output use VoidOutput.
  • Do not output twice the same infos (eg: a status code, an error code saying the same thing...).

@github-project-automation github-project-automation bot moved this to To review in Pull Requests Oct 28, 2025
@github-actions
Copy link
Contributor

🧪 Java Unit Tests

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
Java Tests Report91 ran67 ✅4 ⚠️20 ❌1m 29s 593ms
TestResultTime ⏱
Java Tests Report
DeleteTest.run()❌ failure55ms
DownloadsTest.run_DeleteAfterDownloads()❌ failure45ms
DownloadsTest.run_NoneAfterDownloads()❌ failure8ms
DownloadsTest.[1] dirDelimiter=, fileExtension=❌ failure10ms
DownloadsTest.[2] dirDelimiter=, fileExtension=.txt❌ failure9ms
DownloadsTest.[3] dirDelimiter=/, fileExtension=❌ failure11ms
DownloadsTest.[4] dirDelimiter=/, fileExtension=.txt❌ failure16ms
DownloadsTest.run_shouldDownloadFileWithNameContainingDotsAndSpaces()❌ failure20ms
ListTest.all()❌ failure46ms
MoveTest.moveFileToOther()❌ failure32ms
MoveTest.moveFileWithSpaceToDirectoryWithSpace()❌ failure8ms
MoveTest.moveDirectory()❌ failure8ms
MoveTest.[1] overwrite=true❌ failure8ms
MoveTest.[2] overwrite=false❌ failure9ms
MoveTest.moveFiletoDirectory()❌ failure13ms
TriggerTest.moveAction()❌ failure1s 313ms
TriggerTest.noneAction()❌ failure1s 272ms
UploadTest.upload_destinationIsFolder_overwriteSetToTrue()❌ failure39ms
UploadTest.upload_destinationIsFolder_shouldRaiseAnIssue()❌ failure7ms
UploadsTest.run()❌ failure39ms

@Malaydewangan09
Copy link
Member Author

Malaydewangan09 commented Oct 29, 2025

@fdelbrayelle, the bump in this PR wont work since we are using
api group: 'com.github.new-proimage', name: 'vfs-jcifs-smb', version: '0.9.3' (this is last released in 2021) and it depends on
below:
Screenshot 2025-10-29 at 6 27 27 PM

Do you know any alternatives?

@fdelbrayelle
Copy link
Member

@Malaydewangan09 Try this one instead: https://github.com/hierynomus/smbj and remove jcifs it's only old unsecure SMB1 and not maintained for more than 3 years ⚠️

@Malaydewangan09 Malaydewangan09 changed the title build(deps): bump org.codelibs:jcifs from 2.1.40 to 3.0.0 build(deps): bump + migrate deps (sbm) Oct 31, 2025
@Malaydewangan09 Malaydewangan09 marked this pull request as draft October 31, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: To review

Development

Successfully merging this pull request may close these issues.

2 participants