fix: use onInvalidSyntax properly when invalid flows#247
Open
fdelbrayelle wants to merge 2 commits intomainfrom
Open
fix: use onInvalidSyntax properly when invalid flows#247fdelbrayelle wants to merge 2 commits intomainfrom
fdelbrayelle wants to merge 2 commits intomainfrom
Conversation
Contributor
📦 Artifacts
🧪 Java Unit Tests
🔁 Unreleased Commits2 commits since
|
fdelbrayelle
force-pushed
the
issues/246
branch
from
fb51789 to
86e8df8
Compare
| io.kestra.core.models.flows.Flow parsed = io.kestra.core.serializers.YamlParser.parse(yaml, io.kestra.core.models.flows.Flow.class); | ||
| io.kestra.core.models.flows.Flow parsed; | ||
| try { | ||
| parsed = YamlParser.parse(yaml, io.kestra.core.models.flows.Flow.class); |
Member
There was a problem hiding this comment.
This will only catch flow schema validations and not invalid task definitions e.g some property no longer avaiable or incorrect property name.
Member
Author
There was a problem hiding this comment.
Fix proposal: ef6dbf9
What do you think @Malaydewangan09 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part-of: #246
What changes are being made and why?
How the changes have been QAed?
Setup Instructions
Contributor Checklist ✅