Skip to content

feat(influxdb): add connect/read timeouts#30

Merged
proddata merged 2 commits intomainfrom
feat-influxdb-connect-read-timeouts
Jan 6, 2026
Merged

feat(influxdb): add connect/read timeouts#30
proddata merged 2 commits intomainfrom
feat-influxdb-connect-read-timeouts

Conversation

@proddata
Copy link
Contributor

@proddata proddata commented Jan 5, 2026

What changes are being made and why?

  • Add optional connectTimeout and readTimeout properties on InfluxDBConnection (Duration / ISO-8601, e.g. PT10S)
  • Keep existing behaviour unchanged when timeouts are not set

resolves: #29


Setup Instructions


Contributor Checklist ✅

  • PR Title and commits follows conventional commits
  • Add a closes #ISSUE_ID or fixes #ISSUE_ID in the description if the PR relates to an opened issue.
  • Documentation updated (plugin docs from @Schema for properties and outputs, @Plugin with examples, README.md file with basic knowledge and specifics).
  • Setup instructions included if needed (API keys, accounts, etc.).
  • Prefix all rendered properties by r not rendered (eg: rHost).
  • Use runContext.logger() to log enough important infos where it's needed and with the best level (DEBUG, INFO, WARN or ERROR).

⚙️ Properties

  • Properties are declared with Property<T> carrier type, do not use @PluginProperty.
  • Mandatory properties must be annotated with @NotNull and checked during the rendering.
  • You can model a JSON thanks to a simple Property<Map<String, Object>>.

🧪 Tests

  • Unit Tests added or updated to cover the change (using the RunContext to actually run tasks).
  • Add sanity checks if possible with a YAML flow inside src/test/resources/flows.
  • Avoid disabling tests for CI. Instead, configure a local environment whenever it's possible with .github/setup-unit.sh (to be set executable with chmod +x setup-unit.sh) (which can be executed locally and in the CI) all along with a new docker-compose-ci.yml file (do not edit the existing docker-compose.yml). If needed, create an executable (chmod +x cleanup-unit.sh) cleanup-unit.sh to remove the potential costly resources (tables, datasets, etc).
  • Provide screenshots from your QA / tests locally in the PR description. The goal here is to use the JAR of the plugin and directly test it locally in Kestra UI to ensure it integrates well.

- Add optional connectTimeout and readTimeout properties on InfluxDBConnection (Duration / ISO-8601, e.g. PT10S)
- Keep existing behaviour unchanged when timeouts are not set
- Add FluxReadTimeoutTest that simulates delayed first response bytes and verifies readTimeout failure/success
@kestrabot kestrabot bot added this to Pull Requests Jan 5, 2026
@github-project-automation github-project-automation bot moved this to To review in Pull Requests Jan 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

📦 Artifacts

Name Size Updated Expiration
jar 7.17 MB Jan 6, 26, 11:04:26 AM UTC Jan 13, 26, 11:04:25 AM UTC

🧪 Java Unit Tests

TestsPassed ✅SkippedFailedTime ⏱
Java Tests Report7 ran7 ✅0 ⚠️0 ❌5s 810ms

🔁 Unreleased Commits

✅ No unreleased commits found.

@proddata proddata changed the title feat(influxdb): add connect/read timeouts and regression testw feat(influxdb): add connect/read timeouts Jan 5, 2026
@proddata proddata added the area/plugin Plugin-related issue or feature request label Jan 5, 2026
@proddata proddata merged commit de6a14b into main Jan 6, 2026
3 of 4 checks passed
@proddata proddata deleted the feat-influxdb-connect-read-timeouts branch January 6, 2026 11:07
@github-project-automation github-project-automation bot moved this from To review to Done in Pull Requests Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/plugin Plugin-related issue or feature request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add a timeout parameter to the query tasks

2 participants