test(shell): add outputFilesPebbleExpression test#360
Open
fdelbrayelle wants to merge 2 commits intomainfrom
Open
test(shell): add outputFilesPebbleExpression test#360fdelbrayelle wants to merge 2 commits intomainfrom
fdelbrayelle wants to merge 2 commits intomainfrom
Conversation
Locks in the contract that {{ outputFiles.name }} resolves to the
correct absolute path inside a Script body, as fixed in kestra-io/kestra#13765.
Requires a kestraVersion bump to pick up the core fix before this
test can pass in CI.
Contributor
🧪 Java Unit Tests
|
Malaydewangan09
approved these changes
Apr 27, 2026
fdelbrayelle
force-pushed
the
test/output-files-pebble-expression
branch
from
7371ad8 to
3262a07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
releases/v1.3.x.Summary
Adds
outputFilesPebbleExpressiontest toScriptTestto lock in the contract that{{ outputFiles.name }}resolves to the correct absolute path inside a ShellScriptbody.This is the plugin-scripts counterpart to kestra-io/kestra#13765 / kestra-io/kestra#15725 (the core fix). The test will not pass in CI until
kestraVersioningradle.propertiesis bumped to a version that includes the core fix.Test logic:
outputFiles: ["outfile"]Property.ofExpression()for the script body so Pebble rendering runs (simulates YAML deserialization)echo -n {{ outputFiles.outfile }} > outfile— writes the resolved path to the file/outfile(i.e., the Pebble expression resolved to the working-dir path)Test plan
./gradlew :plugin-script-shell:test --tests "*ScriptTest.outputFilesPebbleExpression*"passes afterkestraVersionbump