Forward release CI workflow subsets#5
Merged
Conversation
Coverage Report for CI Build 29630952401Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.05%) to 89.805%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
π - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR extends kettle-family release to accept a CI workflow subset (--ci-workflows) and forwards that subset through to member kettle-release invocations, while preserving default behavior when the option is not provided.
Changes:
- Add
--ci-workflows LISTtokettle-family releaseand plumb it throughCLI -> Workflow. - Forward the subset to
kettle-releasevia both CLI args (--ci-workflows=...) and environment (K_RELEASE_CI_WORKFLOWS). - Update specs and changelog to cover/document the new option.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/kettle/family/workflow_release_spec.rb | Updates expectations for forwarded kettle-release command to include --ci-workflows. |
| spec/kettle/family/cli_spec.rb | Adds CLI coverage ensuring --ci-workflows is forwarded into the generated release command. |
| lib/kettle/family/workflow.rb | Adds ci_workflows plumbing and appends it to kettle-release args/env. |
| lib/kettle/family/cli.rb | Adds --ci-workflows option and forwards it into Workflow.new. |
| CHANGELOG.md | Documents the new --ci-workflows option. |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Addressed the review feedback in 02d99bf:
Validation:
|
pboling
force-pushed
the
ci/release-workflow-subsets
branch
from
July 18, 2026 00:08
a7234f6 to
17caf09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kettle-family release --ci-workflowskettle-releasecommandsValidation
K_SOUP_COV_DO=false bundle exec kettle-test spec/kettle/family/workflow_release_spec.rb spec/kettle/family/cli_spec.rbK_SOUP_COV_DO=false bundle exec kettle-testbin/rake rubocop_gradual:autocorrectgit diff --check