Skip to content

Forward release CI workflow subsets#5

Merged
pboling merged 9 commits into
mainfrom
ci/release-workflow-subsets
Jul 18, 2026
Merged

Forward release CI workflow subsets#5
pboling merged 9 commits into
mainfrom
ci/release-workflow-subsets

Conversation

@pboling

@pboling pboling commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary

  • add kettle-family release --ci-workflows
  • forward the workflow subset to member kettle-release commands
  • keep the default behavior unchanged when no subset is passed

Validation

  • K_SOUP_COV_DO=false bundle exec kettle-test spec/kettle/family/workflow_release_spec.rb spec/kettle/family/cli_spec.rb
  • K_SOUP_COV_DO=false bundle exec kettle-test
  • bin/rake rubocop_gradual:autocorrect
  • git diff --check

Copilot AI review requested due to automatic review settings July 17, 2026 23:18
@coveralls

coveralls commented Jul 17, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29630952401

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more β†’

Coverage increased (+0.05%) to 89.805%

Details

  • Coverage increased (+0.05%) from the base build.
  • Patch coverage: 12 of 12 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2489
Covered Lines: 2370
Line Coverage: 95.22%
Relevant Branches: 1042
Covered Branches: 801
Branch Coverage: 76.87%
Branches in Coverage %: Yes
Coverage Strength: 50.0 hits per line

πŸ’› - Coveralls

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends kettle-family release to accept a CI workflow subset (--ci-workflows) and forwards that subset through to member kettle-release invocations, while preserving default behavior when the option is not provided.

Changes:

  • Add --ci-workflows LIST to kettle-family release and plumb it through CLI -> Workflow.
  • Forward the subset to kettle-release via both CLI args (--ci-workflows=...) and environment (K_RELEASE_CI_WORKFLOWS).
  • Update specs and changelog to cover/document the new option.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
spec/kettle/family/workflow_release_spec.rb Updates expectations for forwarded kettle-release command to include --ci-workflows.
spec/kettle/family/cli_spec.rb Adds CLI coverage ensuring --ci-workflows is forwarded into the generated release command.
lib/kettle/family/workflow.rb Adds ci_workflows plumbing and appends it to kettle-release args/env.
lib/kettle/family/cli.rb Adds --ci-workflows option and forwards it into Workflow.new.
CHANGELOG.md Documents the new --ci-workflows option.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/kettle/family/workflow.rb Outdated
Comment thread lib/kettle/family/workflow.rb
@pboling

pboling commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

Addressed the review feedback in 02d99bf:

  • Kettle::Family::Workflow#initialize now accepts trailing keyword arguments
  • --ci-workflows values are validated before being forwarded into the shell-backed kettle-release command
  • added CLI and workflow specs for unsafe workflow subset values
  • fixed the existing RuboCop Gradual work-list item, which let the owning task remove .rubocop_gradual.lock

Validation:

  • K_SOUP_COV_DO=false bundle exec kettle-test spec/kettle/family/workflow_release_spec.rb spec/kettle/family/cli_spec.rb spec/kettle/family/dependency_floor_spec.rb
  • bin/rake rubocop_gradual:autocorrect
  • git diff --check

@pboling
pboling force-pushed the ci/release-workflow-subsets branch from a7234f6 to 17caf09 Compare July 18, 2026 00:08
@pboling
pboling merged commit 7773081 into main Jul 18, 2026
12 of 13 checks passed
@pboling
pboling deleted the ci/release-workflow-subsets branch July 18, 2026 04:41
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
kettle-family 95% 77% βž–
Summary 95% (2370 / 2489) 77% (801 / 1042) βž–

Minimum allowed line rate is 92%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants