Added Retries to requests to kong #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror return by kong, getService returns a nil Service. This is incorrect because it leads the client to think the object no longer exists.
This reverts commit d9b59b5
…n 500 error return by kong, getService returns a nil Service. This is incorrect because it leads the client to think the object no longer exists." This reverts commit 5a509a4
…travis ci to break
Author
|
I have no idea why travis-ci is breaking. I ran Also, none of the files that travis-ci is complaining about was modified in this PR. |
kevholditch
requested changes
Dec 16, 2018
Owner
kevholditch
left a comment
kevholditch
left a comment
There was a problem hiding this comment.
you just need do to do a make goimports then check in again so the build passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #29. It adds retries and sleep intervals before returning error. The default max retries is 10 but is changeable via environment variable. The default sleep interval before try is 5 seconds but is changeable via environment variable.