Skip to content

Fix typo#691

Merged
kevin-lee merged 1 commit into
mainfrom
fix-typo
Dec 13, 2025
Merged

Fix typo#691
kevin-lee merged 1 commit into
mainfrom
fix-typo

Conversation

@kevin-lee

Copy link
Copy Markdown
Owner

Fix typo

@kevin-lee kevin-lee added this to the v2-m5 milestone Dec 13, 2025
@kevin-lee kevin-lee requested a review from Copilot December 13, 2025 03:46
@kevin-lee kevin-lee self-assigned this Dec 13, 2025
@github-actions github-actions Bot added pr PR v2 Effectie v2 labels Dec 13, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request corrects a spelling typo in variable names across test files. The variable expectedExpcetion (missing the letter 'i' in "Exception") is being corrected to expectedException throughout the codebase.

Key Changes:

  • Corrected spelling of expectedExpcetion to expectedException in variable declarations and usage
  • Changes are consistent across all Scala test files in multiple modules (effectie-syntax and effectie-monix3)
  • The fix applies to both Scala 2 and Scala 3 test files across JVM, JS, and Native platforms

Reviewed changes

Copilot reviewed 54 out of 153 changed files in this pull request and generated no comments.

Show a summary per file
File Description
modules/effectie-syntax/native/src/test/scala-3/effectie/syntax/errorSpec.scala Fixed typo in variable names used in error handling test cases
modules/effectie-syntax/native/src/test/scala-2/effectie/syntax/errorSpec.scala Fixed typo in variable names used in error handling test cases
modules/effectie-syntax/jvm/src/test/scala-3/effectie/syntax/errorSpec.scala Fixed typo in variable names used in error handling test cases
modules/effectie-syntax/jvm/src/test/scala-2/effectie/syntax/errorSpec.scala Fixed typo in variable names used in error handling test cases
modules/effectie-syntax/js/src/test/scala/effectie/syntax/errorSpec.scala Fixed typo in variable names used in error handling test cases
modules/effectie-monix3/shared/src/test/scala/effectie/instances/monix3/canRecoverIdSpec.scala Fixed typo in variable names used in recovery test cases
modules/effectie-monix3/shared/src/test/scala/effectie/instances/monix3/canHandleErrorIdSpec.scala Fixed typo in variable names used in error handling test cases
modules/effectie-monix3/shared/src/test/scala/effectie/instances/monix3/canCatchIdSpec.scala Fixed typo in variable names used in catch test cases
modules/effectie-monix3/shared/src/test/scala-3/effectie/syntax/errorIdSpec.scala Fixed typo in variable names used in error handling test cases
modules/effectie-monix3/shared/src/test/scala-2/effectie/syntax/errorIdSpec.scala Fixed typo in variable names used in error handling test cases
modules/effectie-monix3/jvm/src/test/scala/effectie/instances/monix3/onNonFatalSpec.scala Fixed typo in variable names used in non-fatal error test cases
modules/effectie-monix3/jvm/src/test/scala/effectie/instances/monix3/f/fxSpec.scala Fixed typo in variable names used in effect test cases
modules/effectie-monix3/jvm/src/test/scala/effectie/instances/monix3/f/canRecoverSpec.scala Fixed typo in variable names used in recovery test cases
modules/effectie-monix3/jvm/src/test/scala/effectie/instances/monix3/f/canHandleErrorSpec.scala Fixed typo in variable names used in error handling test cases
modules/effectie-monix3/jvm/src/test/scala/effectie/instances/monix3/f/canCatchSpec.scala Fixed typo in variable names used in catch test cases
modules/effectie-monix3/jvm/src/test/scala-3/effectie/syntax/errorSpec.scala Fixed typo in variable names used in error handling test cases
modules/effectie-monix3/jvm/src/test/scala-3/effectie/instances/monix3/canCatchSpec.scala Fixed typo in variable names used in catch test cases
modules/effectie-monix3/jvm/src/test/scala-2/effectie/instances/monix3/canCatchSpec.scala Fixed typo in variable names used in catch test cases (includes commented code)
modules/effectie-monix3/js/src/test/scala/effectie/instances/monix3/onNonFatalSpec.scala Fixed typo in variable names used in non-fatal error test cases

This is a straightforward spelling correction that improves code readability and professionalism. The changes are consistent across all occurrences and do not affect functionality.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Dec 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.32%. Comparing base (8f1d0d6) to head (ee9c7ee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files          86       86           
  Lines         582      582           
  Branches       23       21    -2     
=======================================
  Hits          549      549           
  Misses         33       33           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevin-lee kevin-lee merged commit cd058d7 into main Dec 13, 2025
21 checks passed
@kevin-lee kevin-lee deleted the fix-typo branch December 13, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr PR v2 Effectie v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants