Deduped requests in cassettes #603
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@IvanMalison curious what you think of this PR! |
Collaborator
Author
|
@kevin1024 friendly reminder here! Happy to help maintain this repo if you’d like to add me as a maintainer. |
Owner
|
I would love to have another maintainer! Welcome to the team! |
Collaborator
Author
|
@kevin1024 awesome, thank you! I'll try to review some PRs soon. Any ideas on how to fix my test code? |
iloveitaly
force-pushed
the
deduped-cassettes
branch
from
446a595 to
5ebc0e7
Compare
kevin1024
force-pushed
the
master
branch
3 times, most recently
from
df3997c to
34d5384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified this PR to support deduplicating requests in a cassette. This will help users eliminate this issue caused by duplicate recorded requests in a cassette.
I couldn't figure out to run
save_cassettein a test, but I included my (broken) test code in case someone else can point me in the right direction or collaborate on this PR.