Fixed missing version_string attribute when used with urllib3>=2.3.0
#889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urllib3 in v2.3.0 introduced attribute `version_string` (https://github.com/urllib3/urllib3/pull/3316/files). This attribute is missing in `VCRHTTPResponse` which causes errors like AttributeError: 'VCRHTTPResponse' object has no attribute 'version_string' This fixes kevin1024#888
jairhenrique
approved these changes
Dec 28, 2024
|
When will it be part of official build in pypi? |
Owner
|
Once I find the time to make a release :) |
|
@kevin1024 Is there anything contributors can do to help get this released sooner? |
Owner
|
OK new release just dropped that should resolve this issue. Thanks everyone for your patience and have a happy new year! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urllib3 in v2.3.0 introduced attribute
version_string(https://github.com/urllib3/urllib3/pull/3316/files). This attribute is missing inVCRHTTPResponsewhich causes errors like AttributeError: 'VCRHTTPResponse' object has no attribute 'version_string'This fixes #888