Fix RuntimeError when using httpcore with pytest-asyncio #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pytest-asyncio has an event loop running, the original code used asyncio.ensure_future() which returns a Future but never awaits it, causing 'RuntimeError: await wasn't used with future'. This fix runs the async function in a new thread with its own event loop when an event loop is already running, ensuring the synchronous caller gets the actual result instead of a Future object. Fixes compatibility with Python 3.13+ and pytest-asyncio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick claude code PR if it's helpful; just using this locally when I ran into an issue; threadpool feels a bit heavyweight, but it solved my issue.
Problem
When using VCRpy with httpcore and pytest-asyncio (especially with Python 3.13+), the following error occurs:
This happens because when pytest-asyncio already has an event loop running,
_run_async_functionusesasyncio.ensure_future()which returns a Future object but never awaits it. The synchronous caller then receives a Future instead of the actual result, causing the RuntimeError.Solution
This PR fixes the issue by running the async function in a new thread with its own event loop when an event loop is already running. This ensures the synchronous caller receives the actual result instead of a Future object.
The fix uses
concurrent.futures.ThreadPoolExecutorto: