Patch httpx transports instead of httpcore#972
Open
seowalex wants to merge 2 commits intokevin1024:masterfrom
Open
Patch httpx transports instead of httpcore#972seowalex wants to merge 2 commits intokevin1024:masterfrom
seowalex wants to merge 2 commits intokevin1024:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While #943 brings a lot of advantages by moving the patch target to a lower level, it inadvertently broke the use of custom transports that do not wrap the default transports (see #968). To ensure that both entirely custom transports and custom transports that wrap the default transports work with VCR.py, we change the patch target to the transport level instead.
This necessitates wrapping each transport that HTTPX supports, such as
HTTPTransport,AyncHTTPTransport,WSGITransport,ASGITransportandMockTransport. I have also added support forCurlTransportandAsyncCurlTransportfrom https://github.com/vgavro/httpx-curl-cffi, which seems to be the only popular alternative transport I can find on GitHub.This also fixes a bug found in #977 causing the connection pool to be exhausted due to not properly closing the original response stream.