Fix aiohttp ignore_localhost consuming response body#978
Open
AronsonDan wants to merge 1 commit intokevin1024:masterfrom
Open
Fix aiohttp ignore_localhost consuming response body#978AronsonDan wants to merge 1 commit intokevin1024:masterfrom
AronsonDan wants to merge 1 commit intokevin1024:masterfrom
Conversation
When ignore_localhost=True and a request targets localhost, record_responses() would call response.read() to capture the body before cassette.append() checked filter_request(). For ignored hosts the response was never saved, but the body stream was already consumed, causing IncompleteReadError for callers that subsequently tried to read the response (e.g. aiobotocore). Skip record_responses() entirely when filter_request() indicates the request should be ignored. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignore_localhost=True(orignore_hosts) is set,record_responses()eagerly callsresponse.read()to capture the body beforecassette.append()checksfilter_request(). For ignored hosts, the response is never saved to the cassette, but the body stream is already consumed. This causesIncompleteReadErrorfor callers that subsequently try to read the response (e.g. aiobotocore reading S3 responses from moto).record_responses()entirely whenfilter_request()indicates the request should be ignored, preserving the response body for the caller.test_aiohttp.py.Test plan
test_ignore_localhost_does_not_consume_response_bodypasses🤖 Generated with Claude Code