bug: fixes #221 wrong latest version#222
Merged
Merged
Conversation
kevincobain2000
commented
Sep 28, 2025
| if gb.hasModFile() { | ||
| modVersion = gb.getModVersion() | ||
| modVersion = extractMajorVersion(modVersion) | ||
| // modVersion = extractMajorVersion(modVersion) |
Owner
Author
There was a problem hiding this comment.
no longer needed, should provide full version
kevincobain2000
commented
Sep 28, 2025
| os.Exit(1) | ||
| } | ||
| // if version has 3 dots, then remove the @latest or @dev-latest | ||
| if strings.Count(version, ".") == 2 { |
Owner
Author
There was a problem hiding this comment.
not sure when this was pushed by GO but seems like all the old versions are now following proper semantics.
Example in the past 1.9 was just 1.9 and hitting a 1.9.0 ended up in 404 and was not in tags either.
Current remote tags are as:
~/g/gobrew (feature/latest)> go run ./cmd/gobrew ls-remote (base)
==> [Info] Fetching remote versions
1.5 1.5.0 1.5.1 1.5.2 1.5.3 1.5.4
1.5beta1 1.5beta2 1.5beta3 1.5rc1
1.6 1.6.0 1.6.1 1.6.2 1.6.3 1.6.4
1.6beta1 1.6beta2 1.6rc1 1.6rc2
1.7 1.7.0 1.7.1 1.7.2 1.7.3 1.7.4
1.7.5 1.7.6
1.7beta1 1.7beta2 1.7rc1 1.7rc2 1.7rc3 1.7rc4
1.7rc5 1.7rc6
1.8 1.8.0 1.8.1 1.8.2 1.8.3 1.8.4
1.8.5 1.8.6 1.8.7
1.8.5rc4 1.8.5rc5 1.8beta1 1.8beta2 1.8rc1 1.8rc2
1.8rc3
1.9 1.9.0 1.9.1 1.9.2 1.9.3 1.9.4
1.9.5 1.9.6 1.9.7
1.9beta1 1.9beta2 1.9rc1 1.9rc2
1.10 1.10.0 1.10.1 1.10.2 1.10.3 1.10.4
1.10.5 1.10.6 1.10.7 1.10.8
1.10beta1 1.10beta2 1.10rc1 1.10rc2
1.11 1.11.0 1.11.1 1.11.2 1.11.3 1.11.4
1.11.5 1.11.6 1.11.7 1.11.8 1.11.9 1.11.10
1.11.11 1.11.12 1.11.13
1.11beta1 1.11beta2 1.11beta3 1.11rc1 1.11rc2
1.12 1.12.0 1.12.1 1.12.2 1.12.3 1.12.4
1.12.5 1.12.6 1.12.7 1.12.8 1.12.9 1.12.10
1.12.11 1.12.12 1.12.13 1.12.14 1.12.15 1.12.16
1.12.17
1.12beta1 1.12beta2 1.12rc1
1.13 1.13.0 1.13.1 1.13.2 1.13.3 1.13.4
1.13.5 1.13.6 1.13.7 1.13.8 1.13.9 1.13.10
1.13.11 1.13.12 1.13.13 1.13.14 1.13.15
1.13beta1 1.13rc1 1.13rc2
1.14 1.14.0 1.14.1 1.14.2 1.14.3 1.14.4
1.14.5 1.14.6 1.14.7 1.14.8 1.14.9 1.14.10
1.14.11 1.14.12 1.14.13 1.14.14 1.14.15
1.14beta1 1.14rc1
1.15 1.15.0 1.15.1 1.15.2 1.15.3 1.15.4
1.15.5 1.15.6 1.15.7 1.15.8 1.15.9 1.15.10
1.15.11 1.15.12 1.15.13 1.15.14 1.15.15
1.15beta1 1.15rc1 1.15rc2
1.16 1.16.0 1.16.1 1.16.2 1.16.3 1.16.4
1.16.5 1.16.6 1.16.7 1.16.8 1.16.9 1.16.10
1.16.11 1.16.12 1.16.13 1.16.14 1.16.15
1.16beta1 1.16rc1
1.17 1.17.0 1.17.1 1.17.2 1.17.3 1.17.4
1.17.5 1.17.6 1.17.7 1.17.8 1.17.9 1.17.10
1.17.11 1.17.12 1.17.13
1.17beta1 1.17rc1 1.17rc2
1.18 1.18.0 1.18.1 1.18.2 1.18.3 1.18.4
1.18.5 1.18.6 1.18.7 1.18.8 1.18.9 1.18.10
1.18beta1 1.18beta2 1.18rc1
1.19 1.19.0 1.19.1 1.19.2 1.19.3 1.19.4
1.19.5 1.19.6 1.19.7 1.19.8 1.19.9 1.19.10
1.19.11 1.19.12 1.19.13
1.19beta1 1.19rc1 1.19rc2
1.20 1.20.0 1.20.1 1.20.2 1.20.3 1.20.4
1.20.5 1.20.6 1.20.7 1.20.8 1.20.9 1.20.10
1.20.11 1.20.12 1.20.13 1.20.14
1.20rc1 1.20rc2 1.20rc3
1.21 1.21.0 1.21.1 1.21.2 1.21.3 1.21.4
1.21.5 1.21.6 1.21.7 1.21.8 1.21.9 1.21.10
1.21.11 1.21.12 1.21.13
1.21rc1 1.21rc2 1.21rc3 1.21rc4
1.22 1.22.0 1.22.1 1.22.2 1.22.3 1.22.4
1.22.5 1.22.6 1.22.7 1.22.8 1.22.9 1.22.10
1.22.11 1.22.12
1.22rc1 1.22rc2
1.23 1.23.0 1.23.1 1.23.2 1.23.3 1.23.4
1.23.5 1.23.6 1.23.7 1.23.8 1.23.9 1.23.10
1.23.11 1.23.12
1.23rc1 1.23rc2
1.24 1.24.0 1.24.1 1.24.2 1.24.3 1.24.4
1.24.5 1.24.6 1.24.7
1.24rc1 1.24rc2 1.24rc3
1.25 1.25.0 1.25.1
1.25rc1 1.25rc2 1.25rc3
juev
approved these changes
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #221
Not sure about windows build. Tests are passing now after vups.
I think this README.md needs to be updated, it says update
latest, while it should be updategolang-tags.json? And not sure how to update thelatestThanks for checking @juev